Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"isHeaderViewVisible" only hide the subview without resizing the timelinePageViewer #338

Open
3 tasks done
Jhegs opened this issue Jun 7, 2022 · 1 comment
Open
3 tasks done
Labels

Comments

@Jhegs
Copy link

Jhegs commented Jun 7, 2022

New Issue Checklist

Issue Description

After to set the property to false, this sentence only hide the dayHeaderView view leaving a white space
(The green background is just for reference)

myView.isHeaderViewVisible = false

Screen Shot 2022-06-07 at 17 30 45

Result I am trying to achieve

The possible fix that needs a change in the library.

I did a small change on the file DayView (inside CalendarKit) project removing the else

// Before
override public func layoutSubviews() {
    super.layoutSubviews()
    if #available(iOS 11, *) {} else {
        ...
    }
  }

// After
override public func layoutSubviews() {
    super.layoutSubviews()
    if #available(iOS 11, *) { // Removing the else case
        ...
    }
  }

and the frame is recalculated.

Screen Shot 2022-06-07 at 17 36 49

Final Note

To be sure that I'm not doing something wrong in my project I did the same change trying with the CalendarKitDemo project inside this repository and the bug is present.

Screen Shot 2022-06-07 at 18 14 58

@Jhegs Jhegs added the bug label Jun 7, 2022
@richardtop
Copy link
Owner

It's a confirmed bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants