Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current time indicator for all dates. #358

Closed
littlehj opened this issue May 27, 2023 · 6 comments
Closed

Current time indicator for all dates. #358

littlehj opened this issue May 27, 2023 · 6 comments

Comments

@littlehj
Copy link

The current time indicator, which shows the current time, is only displayed if it is today. It would be a nice option for CalendarKit if it could be improved to be visible on all dates.

CleanShot 2023-05-27 at 20 27 57@2x

Thanks.

@richardtop
Copy link
Owner

Could you please elaborate on your idea? Do you propose to have an option to show current time even for e.g. yesterday or any other day in the past/future? Which color should that indicator have?

Currently it just mimics the default Calendar app behavior, which is to show it just for "today".

@littlehj
Copy link
Author

Currently, the time indicator is only shown if it is today, like the default Calender app.
However, I realized that it would be much more helpful to show the current time when adjusting past or future events.
I'm suggesting this because I think such a time indicator would be a good UI reference for users when adding new events or modifying existing ones.

@richardtop
Copy link
Owner

I suggest you modifying the library (forking) and then adjusting the logic of hiding that time indicator. e.g. you might change the color of the indicator for other dates than today, the relevant code is here: https://github.com/richardtop/CalendarKit/blob/master/Sources/Timeline/TimelineView.swift#L382

@littlehj
Copy link
Author

I suggest you modifying the library (forking) and then adjusting the logic of hiding that time indicator. e.g. you might change the color of the indicator for other dates than today, the relevant code is here: https://github.com/richardtop/CalendarKit/blob/master/Sources/Timeline/TimelineView.swift#L382

Thanks,

@richardtop
Copy link
Owner

Were you able to achieve the result you intended? Can this ticket be closed?

@littlehj
Copy link
Author

littlehj commented Jun 6, 2023

YES. Thanks for great support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants