Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Test Failure: h3ToGeoBoundary_classIIIEdgeVertex #1

Closed
RichardVasquez opened this issue Jan 26, 2021 · 1 comment
Closed

Unit Test Failure: h3ToGeoBoundary_classIIIEdgeVertex #1

RichardVasquez opened this issue Jan 26, 2021 · 1 comment
Assignees
@RichardVasquez
Labels
bug Something isn't working

Comments

@RichardVasquez
Copy link
Owner

TestSuite.TestH3Api.h3ToGeoBoundary_classIIIEdgeVertex

Expected: 7
But was: 8

at TestSuite.TestH3Api.h3ToGeoBoundary_classIIIEdgeVertex() in C:\Users\catch\Documents\JetBrainsGitHub\h3\Tests\NUnit\H3Suite\TestH3Api.cs:line 45
@RichardVasquez RichardVasquez added the bug Something isn't working label Jan 26, 2021
@RichardVasquez RichardVasquez self-assigned this Jan 26, 2021
@RichardVasquez
Copy link
Owner Author

Fixed by modifying Constants.H3.DBL_EPSILON to a more forgiving value. It looks like C# may have a higher margin of inaccuracy in its trig functions as implied here: dotnet/runtime#8528

Until this gets updated with a high precision trig library,l I'm willing to work with the lower accuracy.

Repository owner locked as resolved and limited conversation to collaborators Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RichardVasquez RichardVasquez

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RichardVasquez