Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TL discriminator for skill defaults #813

Open
rinickolous opened this issue Feb 16, 2024 · 0 comments
Open

Add TL discriminator for skill defaults #813

rinickolous opened this issue Feb 16, 2024 · 0 comments

Comments

@rinickolous
Copy link
Sponsor

Some skills have different defaults depending on TL. An example of this is the Armoury skill in Basic Set, which has different defaults based on its TL.

I propose adding a NumericCriteria to the SkillDefaults object, omitted from the data if set to "any", which causes the skill default to apply only if the criteria is met.

An alternative to this would be making duplicate listings in the various libraries for skills to which this applies. However, this seems more elegant and should be simple to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants