Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple ECUs on single connection #45

Closed
happyh66 opened this issue Jan 15, 2019 · 2 comments
Closed

Support for multiple ECUs on single connection #45

happyh66 opened this issue Jan 15, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@happyh66
Copy link
Collaborator

No description provided.

@happyh66 happyh66 created this issue from a note in UdsCommunication (Tasks) Jan 15, 2019
@happyh66 happyh66 self-assigned this Jan 15, 2019
@happyh66 happyh66 added the enhancement New feature or request label Jan 15, 2019
@happyh66
Copy link
Collaborator Author

The initial implementation does not allow for more than one ECU (Uds class) to use a shared 'bus' connection. This is due to the 'bus' being tightly coupled to the CanTp class (one-to-one with Uds class also). Idea would be to create a small additional class to encapsulate the CAN Connection. This would contain the bus and allow multiple callbacks (CanTp instances). It is also possible to add filters (which CAN Ids are let through) to the bus - so this could be implemented in this new class.

@happyh66
Copy link
Collaborator Author

The CanConnection.py class has been created to add encapsulation of the Bus instance + add the ability to add multiple callbacks. The CanConnectionFactory class has been modified accordingly. Tested with a single hardware interface (both Peak & Vector) and two Uds/CanTp ECU connections from a test python script - using threads performed multiple RDBI requests to both ECUs simultaneously & also simultaneous software download.

@richClubb richClubb moved this from Tasks to In Progress in UdsCommunication Mar 5, 2019
@richClubb richClubb moved this from In Progress to Completed in UdsCommunication Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
UdsCommunication
  
Completed
Development

No branches or pull requests

1 participant