Add options object to allow finer-grained validation #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+8
to
+16
| function validate(issn, options) { | ||
| var opts = options ? options : { strict: false }; | ||
|
|
||
| var issnPattern = opts.strict === true | ||
| ? '^(\\d{4})-(\\d{3})([\\dX])$' // hyphen is required | ||
| : '^(\\d{4})-?(\\d{3})([\\dX])$'; // hyphen is optional | ||
| var isIssn = new RegExp(issnPattern); | ||
|
|
||
| var matches = text(issn).match(isIssn); |
There was a problem hiding this comment.
Updated the validation logic to support stricter validation.
| "jasmine-node": "3.0.0", | ||
| "lodash": "^4.17.21" | ||
| }, | ||
| "dependencies": { | ||
| "get-stdin": "7.0.0", | ||
| "minimist": "^1.2.6" |
There was a problem hiding this comment.
Swapped from minimist to yargs only 'cos there was a bug in testing the CLI with the new stricter validation option.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "issn", | |||
| "version": "1.0.6", | |||
| "version": "2.0.0", | |||
There was a problem hiding this comment.
Major version bump because the function signature is changing: the options argument is optional but it's still a change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47