Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write script to create fig 2 #2

Closed
richelbilderbeek opened this issue Jan 21, 2019 · 4 comments
Closed

Write script to create fig 2 #2

richelbilderbeek opened this issue Jan 21, 2019 · 4 comments
Assignees

Comments

@richelbilderbeek
Copy link
Owner

The article shows how to create fig 2, but a script to really do so is lacking now.

Create a script to create fig 2. The figure should be saved as figure_2.png in folder the script is in.

@richelbilderbeek
Copy link
Owner Author

I think Giovanni will like this one...

@Giappo
Copy link
Collaborator

Giappo commented Jan 23, 2019

I suppose that if figure 2 has to be published we need to show the results for a very big amount of data. This data should be stored in some format, which I don't really know at the moment.
Furthermore I suppose that it should be obtained, according to the article, calling the function pir_plot.
Can you give me an example of results produced in the right format?

@richelbilderbeek
Copy link
Owner Author

I suppose that if figure 2 has to be published we need to show the results for a very big amount of data. This data should be stored in some format, which I don't really know at the moment.

I think in this context, using the defaults settings is fine (for raket/razzo, things will be different). I feel it not useful enough, but If you feel the urge the resulting data frames, go ahead 👍. I hope you'll postpone this until the last phase, else we'll have to maintain these (i.e. re-create every time we create a new return value for pir_run).

Furthermore I suppose that it should be obtained, according to the article, calling the function pir_plot. Can you give me an example of results produced in the right format?

Indeed I underdocumented it 😊, I've added it now. I hope this suffices 🌈

@Giappo
Copy link
Collaborator

Giappo commented Jan 28, 2019

Probably done, please take a look, re-open iff needed 🌈

@Giappo Giappo closed this as completed Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants