Feature: implement tracing logs as a feature
#209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need lot of cleanup
…s in a minor version)
|
Eh, clippy don't pass ( https://github.com/richerarc/saphir/actions/runs/3132727251/jobs/5085367660 ) but I'm curious as to why it's not caught on my end 🤔 |
Fixed |
LucFauvel
requested changes
Sep 27, 2022
richerarc
approved these changes
Sep 28, 2022
LucFauvel
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the request tracing is integrated into the handler code instead of as a middleware to be able to wrap the FileMiddleware log span within the request span regardless of middleware order.
This PR also fix controller macro's handler span so that tracing span within the macro output have proper line numbers, instead of pointing to the top #[controller] macro.