Simplify wuffs_decode implementation #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wuffs has a low-level C API, necessary if e.g. decoding an animated image (or decoding incrementally over the network) while concurrently doing other work, and a high-level C++ API. fpng_test just wants to decode a still (non-animated) PNG image whose compressed form is entirely in memory, so it can use the simpler C++ API.
This makes it clearer that the caller is responsible for freeing the returned pixel buffer p. Freeing may be implicit, RAII style, when the std::unique_ptr p goes out of scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wuffs has a low-level C API, necessary if e.g. decoding an animated
image (or decoding incrementally over the network) while concurrently
doing other work, and a high-level C++ API. fpng_test just wants to
decode a still (non-animated) PNG image whose compressed form is
entirely in memory, so it can use the simpler C++ API.