-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different JSON structures from providers #9
Comments
@tohagan yes very good point. I'm happy to accept a pull request for this, otherwise I can probably work on it this weekend. |
Some also now require an access key that you could include as an input. The result they return can depend on whether you present a key. Of course each provider wants their own key so again you need to provide a customisation (key + transform fn) per provider. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Each of the providers produces slightly different JSON structures. So what I think this lib needs is an optional transform function per provider to convert the JSON into a set of common fields.
Some of the providers DO produce similar results so they could become the defacto standard.
The text was updated successfully, but these errors were encountered: