Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different JSON structures from providers #9

Closed
tohagan opened this issue Aug 3, 2018 · 3 comments
Closed

Different JSON structures from providers #9

tohagan opened this issue Aug 3, 2018 · 3 comments
Assignees

Comments

@tohagan
Copy link

tohagan commented Aug 3, 2018

Each of the providers produces slightly different JSON structures. So what I think this lib needs is an optional transform function per provider to convert the JSON into a set of common fields.
Some of the providers DO produce similar results so they could become the defacto standard.

@roryrjb
Copy link
Contributor

roryrjb commented Aug 4, 2018

@tohagan yes very good point. I'm happy to accept a pull request for this, otherwise I can probably work on it this weekend.

@tohagan
Copy link
Author

tohagan commented Aug 4, 2018

Some also now require an access key that you could include as an input. The result they return can depend on whether you present a key. Of course each provider wants their own key so again you need to provide a customisation (key + transform fn) per provider.

@roryrjb roryrjb self-assigned this Oct 2, 2018
@roryrjb roryrjb removed their assignment Oct 9, 2018
@roryrjb roryrjb self-assigned this Oct 21, 2018
@roryrjb
Copy link
Contributor

roryrjb commented Oct 21, 2018

The different structure issue is closed in #14, with an initial implementation. Regarding the need for API keys, I've trimmed the default provider list so none require API keys, but the actual implementation needs to be addressed, I've opened #15 for this. As always PRs are more than welcome! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants