Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observable$1.fromPromise on Angular 7 rxjs 6 #51

Closed
xadim opened this issue Dec 29, 2018 · 3 comments
Closed

Observable$1.fromPromise on Angular 7 rxjs 6 #51

xadim opened this issue Dec 29, 2018 · 3 comments

Comments

@xadim
Copy link

xadim commented Dec 29, 2018

No description provided.

@xadim
Copy link
Author

xadim commented Dec 29, 2018

@richnologies thanks for the useful module, As of rxjs 6.0.0-beta.3, operators and observable creators should be imported from rxjs. Furthermore, fromPromise is not part of the public API anymore and its wrapped in the from method.
This should address it on ngx-stripe/esm5/ngx-stripe.js
import { fromPromise } from 'rxjs/observable/fromPromise';
and use of
fromPromise(stripe.createToken(a, b));
instead of
Observable$1.fromPromise(stripe.createToken(a, b));
Hope that will help otherwise please disregard it.

Thanks-

@xadim xadim changed the title Observable$1.fromPromise needs to be addressed on Angular 7 rxjs 6 Observable$1.fromPromise on Angular 7 rxjs 6 Dec 29, 2018
@iCodr8 iCodr8 mentioned this issue Jan 6, 2019
@martinschurmann
Copy link

I have the same issue :( please fix

@richnologies
Copy link
Owner

That should be fixed in the new version 7.x that has just been published in npm. Please update to the latest version and if the problem persists please open a new issue to let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants