Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HighlightedAreaView.onDidAddSelectedMarker is deprecated. #149

Closed
el-psycho opened this issue Mar 23, 2017 · 7 comments
Closed

HighlightedAreaView.onDidAddSelectedMarker is deprecated. #149

el-psycho opened this issue Mar 23, 2017 · 7 comments

Comments

@el-psycho
Copy link

Deprication warning on highlight-selected 0.13.0, Atom 1.15.0

Please do not use. This method will be removed.

HighlightedAreaView.onDidAddSelectedMarker (/home/kevin/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:67:12)
onDidAddSelectedMarker (/home/kevin/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:3:59)
MinimapHighlightSelected.init (/home/kevin/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected.coffee:63:30)
init (/home/kevin/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected.coffee:3:59)
MinimapHighlightSelected.consumeHighlightSelectedServiceV1 (/home/kevin/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected.coffee:28:21)
Provider.provide (/usr/lib/atom/node_modules/service-hub/lib/provider.js:34:52)
@arsari
Copy link

arsari commented Mar 24, 2017

same with me...

2 Deprecations warning on highlight-selected 0.13.0, Atom 1.15.0

Please do not use. This method will be removed.
REPORT ISSUE
HighlightedAreaView.onDidAddMarker - /Users/arsari/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:62:12
onDidAddMarker - /Users/arsari/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:3:59
MinimapHighlightSelected.init - /Users/arsari/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected.coffee:58:30
init - /Users/arsari/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected.coffee:3:59
MinimapHighlightSelected.consumeHighlightSelectedServiceV1 - /Users/arsari/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected.coffee:28:21
Provider.provide - /Applications/Atom.app/Contents/Resources/app.asar/node_modules/service-hub/lib/provider.js:29:52

Please do not use. This method will be removed.
REPORT ISSUE
HighlightedAreaView.onDidAddSelectedMarker - /Users/arsari/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:67:12
onDidAddSelectedMarker - /Users/arsari/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:3:59
MinimapHighlightSelected.init - /Users/arsari/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected.coffee:63:30
init - /Users/arsari/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected.coffee:3:59
MinimapHighlightSelected.consumeHighlightSelectedServiceV1 - /Users/arsari/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected.coffee:28:21
Provider.provide - /Applications/Atom.app/Contents/Resources/app.asar/node_modules/service-hub/lib/provider.js:29:52

@richrace
Copy link
Member

This pull requested needs to be merged: atom-minimap/minimap-highlight-selected#39

@carrodher
Copy link

Same here for 1.16.0-beta0

@juvevood
Copy link

Same here for 0.13.1

@vitorlee
Copy link

Ver 0.13.1, still not fixed

@akaybagorov
Copy link

+1

@Pulsar-Edit-Highlights Pulsar-Edit-Highlights locked and limited conversation to collaborators Mar 28, 2017
@richrace
Copy link
Member

I've locked this issue as this is caused by another package using an API that causes bugs.

Once this pull request gets merged, the deprecated warnings will go away: atom-minimap/minimap-highlight-selected#39

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants