Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for console.error warnings #25

Closed
schinery opened this issue Mar 6, 2021 · 2 comments
Closed

Option for console.error warnings #25

schinery opened this issue Mar 6, 2021 · 2 comments

Comments

@schinery
Copy link
Contributor

schinery commented Mar 6, 2021

After upgrading Formik in a project that doesn't use this reporter I noticed that I was getting warnings that were using console.error instead of console.warn, and so weren't outputted when showWarnings is set to true.

console.error
      Warning: An update to Formik inside a test was not wrapped in act(...).

Would it be possible to add entry.type === 'error' to the console filtering check for warnings?

@rickhanlonii
Copy link
Owner

Added, thanks for the PR!

@schinery
Copy link
Contributor Author

Nice one! Already have the 0.5.0 version installed and working 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants