Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in KPIC2 default feature param ranges #31

Merged
merged 1 commit into from Dec 23, 2021

Conversation

coltonlloyd
Copy link
Contributor

Thanks for the great package Rick! I noticed a small typo when running parameter optimizations for KPIC2. A default range was missing for min_width which would cause an error when the line below was executed:

if ((diff(settingRange) / 2) < step)

@rickhelmus rickhelmus merged commit 482efba into rickhelmus:master Dec 23, 2021
@rickhelmus
Copy link
Owner

Great, many thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants