fix(tf2): fix critical tf2 gradient update bug #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickstaa
force-pushed
the
fix_tf2_actor_gradient_bug
branch
from
7559be1
to
4e74be5
Compare
This commit fixes a critical bug in the tf2 algorithms, which prevented the `log_std` and `mu` layers from being updated. This was because the `trainable_variables` attribute was called before the `SquasedGaussianActor` was built. It also improves the target network update and network summarize code.
rickstaa
force-pushed
the
fix_tf2_actor_gradient_bug
branch
from
4e74be5
to
48de8c8
Compare
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a critical bug in the tf2 algorithms, which prevented the
log_stdandmulayers from being updated. This was because thetrainable_variablesattribute was called before theSquasedGaussianActorwas built.