Trigger Bell in the Monitored Window #53
Conversation
|
@daneski13 thank you so much for the pull request! That looks like a handy feature 💪🏻! I reviewed your pull request and gave some suggestions. Additionally, please provide users with a way to turn off this feature your feature. Maybe we can add a Apart from those changes, we can merge this in the main branch 🚀! |
Co-authored-by: Rick Staa <rick.staa@outlook.com>
|
@rickstaa Thank you and I'm glad you like this addition! A visual bell will only be visible if the user has However, if you prefer to have the visual bell on by default for all users with a variable to turn it off I'm happy to make that change. |
Your right! The part of the code you improved is written by the original creator of this plugin. After reviewing it again, I think it indeed is a bug in the code, not a new feature 👍🏻. Let's merge this pull request in its current form! |
|
@daneski13 Thanks again for your contribution ❤️🔥! |
|
@rickstaa Of course, no problem! |
Love this plugin, however I do not use tmux's audible bell sound and rely on the visual in my status line/bar instead. It's nice to have the visual confirmation on my tmux status line/bar for which windows in my current session are done with their task after being notified by the OS. For those that rely on tmux's visual bell and not just the audible sound, I've found this change to be a must.
This small PR will have the bell trigger in the window that is being monitored rather than in the currently active window.