Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties.overrideParameters doesn't do anything? #221

Closed
marcsaegesser opened this issue Feb 15, 2016 · 3 comments
Closed

Properties.overrideParameters doesn't do anything? #221

marcsaegesser opened this issue Feb 15, 2016 · 3 comments

Comments

@marcsaegesser
Copy link

Maybe I'm missing something but the Properties.overrideParameters method doesn't seem to actually do anything. The comment says it's supposed to override the test parameters for current Properties class but all it seems to do is return the value it's passed and it doesn't have any impact on the test parameters used by the tests.

/**
 * Changes to the test parameters that are specific to this class.
 * Can be used to set custom parameter values for this test.
 */
def overrideParameters(p: Test.Parameters): Test.Parameters = p
@rickynils
Copy link
Contributor

I think the idea is that you override that function within your Properties instance, and return a modified version of the parameters that will be used when running the tests (for that property collection). The scaladocs are of course not telling you this :) So we can keep this issue open until the docs are fixed.

@marcsaegesser
Copy link
Author

Got it. Thanks.

@ashawley
Copy link
Contributor

Closing this issue. The documentation was fixed in #524. Overriding parameters was also fixed in #522.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants