Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't preserve color space in my case #67

Open
antongaenko opened this issue Oct 22, 2015 · 3 comments
Open

Doesn't preserve color space in my case #67

antongaenko opened this issue Oct 22, 2015 · 3 comments

Comments

@antongaenko
Copy link

Hi! Nice plugin.
I notice problems with generated images when running on device. 3x images look as they should, but 2x have different colors a little. I think in my case it's because 3x images have sRGB IEC61966-2.1 color space, but generated images have Generic RGB Profile (which I think is by default in Plugin?). When I provide both in sRGB IEC61966-2.1 all is OK. My iMac has been set sRGB IEC61966-2.1 in Settings/Monitor.
Where could issue be?

@antongaenko
Copy link
Author

Just reinstall with Package Manager to be sure running last version and it has this issue

@rickytan
Copy link
Owner

Sorry, I don't know quite a lot about color space stuffs, in fact, I tried to preserve the origin image's color space, but sometimes fails: https://github.com/rickytan/RTImageAssets/blob/master/RTImageAssets/IAImageSet.m#L46

Can you help me with this?

@antongaenko
Copy link
Author

I'm not familiar with color space management too 😄 Above code seems well. No thoughts where issue could live...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants