Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rico-Angular: Instanciating multiple controllers "at the same time" mixes up the model references #46

Closed
madmas opened this issue Jan 29, 2019 · 4 comments

Comments

@madmas
Copy link
Member

madmas commented Jan 29, 2019

When multiple controllers are created "at the same time", meaning timely very close to eeach other, the model references of these controllers are mixed up.

Some investigation has shown that this is related to the highlanderPM used in RicoJS tohandle model instanciation. (see https://github.com/rico-projects/rico-js/blob/29f12ed97c1701b77b2c8e0beecca8576f39bdcd/src/remoting/controllerManager.js#L53) .

@hendrikebbers
Copy link
Contributor

I think the best way to fix this is by changing the command batching. Any command that is not a value change command should mark the end of a batch for commands that can be send to the server.

@hendrikebbers
Copy link
Contributor

Removed Angular Label since this is a general JS problem

@madmas
Copy link
Member Author

madmas commented Jan 29, 2019

@hendrikebbers I think these comments belong into #47 or would be seperate issues, first we should adress a fix locally.

@madmas
Copy link
Member Author

madmas commented Jan 30, 2019

Fixed in Rico-Angular by rico-projects/rico-angular#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants