Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle size and v2 #23

Closed
ricokahler opened this issue Apr 30, 2020 · 1 comment
Closed

Bundle size and v2 #23

ricokahler opened this issue Apr 30, 2020 · 1 comment

Comments

@ricokahler
Copy link
Owner

Right now on bundlephobia, oauth2-popup-flow has a bundle size of 1.6kB. This is okay but it could be much smaller. I attribute this to the use of the classes and static methods that a minifier doesn't have the ability to minifiy.

For v2, we'll remove the class and that will probably give us a much smaller bundle size.

@ricokahler
Copy link
Owner Author

Eh i tried this out here: #24

this was the result: https://bundlephobia.com/result?p=@ricokahler/oauth2-popup-flow@2.0.0-alpha.1 vs https://bundlephobia.com/result?p=oauth2-popup-flow@1.1.0

removing the class did help the minified size significantly but the gzip is still the same so I don't think this change is worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant