Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support authorization code grant w/ PKCE #41

Open
Tracked by #135
iclems opened this issue Jun 16, 2020 · 4 comments
Open
Tracked by #135

Support authorization code grant w/ PKCE #41

iclems opened this issue Jun 16, 2020 · 4 comments
Milestone

Comments

@iclems
Copy link

iclems commented Jun 16, 2020

Some authentication services return a "code" as part of the OAuth flow and that eventually needs to be converted into a full token. It'd be great to be able to use afterResponse to perform an API request to convert the temporary code into the token?

@ricokahler
Copy link
Owner

I'm glad you brought this up however I want to give this a bit more thought than what you're currently proposing. This lib was originally written before the implicit grant became "legacy" (see here for context) so really what this lib should do is now fully support the authorization code grant more formally vs utilizing a hook.

I'll try to get something out by end of week.

@ricokahler ricokahler changed the title await afterResponse Support authorization code grant Jun 16, 2020
@iclems
Copy link
Author

iclems commented Jun 17, 2020

@ricokahler thank you for your quick & very interesting reply! I would be happy to help. Looking at the details, it really looks like the flow just needs to have an optional "getToken" function after the initial flow to convert code => token, and an optional "refreshToken" if available. Can I help?

@ricokahler ricokahler changed the title Support authorization code grant Support authorization code grant w/ PKCE Feb 23, 2021
@filipkowal
Copy link

@ricokahler any changes in this matter? Does the library support authorization code flow?

@ricokahler
Copy link
Owner

@filipkowal no this lib was built primarily for the implicit grant but i understand that that's no longer recommended.

i'm a bit busy with a few other projects so if you would like to implement this, i am accepting PRs!

@ricokahler ricokahler mentioned this issue Dec 9, 2021
4 tasks
@ricokahler ricokahler added this to the v2.0.0 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants