Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSweep with a fixed point #5

Closed
ytanimura opened this issue Dec 28, 2020 · 3 comments
Closed

RSweep with a fixed point #5

ytanimura opened this issue Dec 28, 2020 · 3 comments

Comments

@ytanimura
Copy link
Contributor

We are not yet prepared for rotational sweeps with a fixed point. For example, we cannot create even a sphere by simple rotational sweeps.
The biggest difficulty in implementation is that when the surface is created in a naive way, the NURBS surface degenerates around the fixed point and the normal vector at the fixed point cannot be calculated.

@ytanimura
Copy link
Contributor Author

We should create a new enum that enumerates special shapes such as planes and spheres in parallel with NURBS, and add rotators to it.

@ytanimura
Copy link
Contributor Author

In the master branch, we found holes in the cone and gaps in the mesh at the edges. These will be dealt with in due course, but priority will be given to the STEP output first.

@phkahler
Copy link

The biggest difficulty in implementation is that when the surface is created in a naive way, the NURBS surface degenerates around the fixed point and the normal vector at the fixed point cannot be calculated.

I don't think you get much choice in the case of a cone, or any other time a curve ends on the axis of revolution at a non-orthogonal angle. We had the degenerate surface/edge/normal come up in Sovlespace. The discussion around the pull request to fix it is here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants