Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep the fields order same as the source #49

Merged
merged 1 commit into from Nov 7, 2022
Merged

fix: keep the fields order same as the source #49

merged 1 commit into from Nov 7, 2022

Conversation

FerasAloudah
Copy link
Contributor

This should fix the order of the fields when using mixins, I basically wrapped all field setters in setImmediate. This currently passes all tests and outputs the expected schema.
@ridafkih what do you think?

Also, I removed two snapshots that were obsolete.

@ridafkih
Copy link
Owner

ridafkih commented Nov 7, 2022

On a flight! Will have a look once we're at altitude! Thanks so much for the initiative and your contribution!

@FerasAloudah
Copy link
Contributor Author

Happy to help! Have a safe flight!

@ridafkih
Copy link
Owner

ridafkih commented Nov 7, 2022

Fantastic work, will have this merged in now!

@ridafkih ridafkih merged commit 980a96b into ridafkih:main Nov 7, 2022
@ridafkih ridafkih mentioned this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants