-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DomDomSoft Manga Reader program #46
Comments
use: |
Still not working. Maybe because DDS Manga Reader require elevated privillige ? |
It will ask if needed. It's working fine here with
On recent build, path containing space must be inside quote. |
3 cases:
And as you've mentioned, unicode also break the Reader. DomDomSoft's version is 1.4.3, FMD's is 0.9.16.1 |
What is your path to the DMR? Can it work without admin? |
The path is exactly as you see above: I just try running this command with a non-elevated command prompt, it asks for admin right and then launches DMR as expected: Config files are here |
I've been fix the issue with admin privileges and file path. But I still can't pass unicode character in parameter. I don't know, it can be limitation on fpc. |
Can unicode characters be converted to number code in code page UTF-8 or similar to be passed and then reconstructed on the command prompt ? Or maybe use PowerShell instead of Command Prompt ? |
It's already in UTF-8, I've been trying decode/encode without success. It seems it's the issue with fpc. I've been trying to use CreateProcessW ShellExecuteExW without success too. I think that's why the original developers invent an option to remove all unicode character in.filename. |
Case 1 is fixed, but 2 is still not working. Launching DMR always results in error unless both %PATH% and %CHAPTER% is added. Updated: Add |
Launching DMR with "" at the end causing error. Launching DMR with path that doesn't exist is fine, but when launching it with existing path that ended with "", DMR crash. |
I think this commit should fix it. bcf96e5 |
Confirm fixed. DMR isn't supported by DomDomSoft anymore so this bug will continue existing, sadly; but I can't find a good comic reader with long strip mode so just have to put up with it. |
What do you mean DMR isn't supported anymore? |
Forgot to add "by the developers". They've pretty much dropped the project. I'll edit the comment. |
I just fix the issue with unicode character. |
I just look at Honeyview, it seems the development is still alive and well, maybe you can ask them to add long strip view mode. |
You can download it from here: http://domdomsoft.com/
I try using the syntax
"E:\Setups\DomDomSoft Manga Reader\DomDomSoft Manga Reader.exe" "%PATH%"
in external path but it's not working. Instead, the first and last double quotation mark disappear; the program doesn't launch either.
The text was updated successfully, but these errors were encountered: