Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail #9

Open
cryptapus opened this issue Jan 13, 2019 · 1 comment
Open

Tests fail #9

cryptapus opened this issue Jan 13, 2019 · 1 comment
Labels
help wanted Extra attention is needed tests
Milestone

Comments

@cryptapus
Copy link

Currently tests fail for Riecoin. It is a long term goal to have them functional.

@Pttn Pttn added this to the Release 0.18+ milestone May 27, 2019
@Pttn Pttn self-assigned this Jun 13, 2020
@Pttn
Copy link
Member

Pttn commented Jul 15, 2020

I rewrote most tests for Riecoin, but there is still a few things to do.

Some cases should to be recreated in src/test/data/blockfilters.json
CreateNewBlock_validity needs to be rewritten, it is not that trivial as the Fair Launch needs to be taken in account, and rieMiner needs to be adapted in order to find suitable 6-tuples (due to the Offset < 2^39 restriction; rieMiner does not support Extra Nonces).

Some Fuzz Tests fail due to Gmp in Travis, no idea why (see the Travis Logs for 00_setup_env_native_fuzz.sh).

p2p_dos_header_tree.py probably just needs new data.
I don't know why feature_assumevalid.py is failing. As well as the Linearize tools and consequently feature_loadblock.py.
Some tests still need to be adapted to take in account the 2x Block Size and 4x Max SigOps: in feature_block.py, b40 and b41 tests will produce too big blocks and cause unwanted bad-blk-length errors, and need to be rewritten to properly test the bad-blk-sigops error. In test_witness_block_size.py, test_witness_block_size and test_witness_sigops probably just need a few count changes, but I can't seem to find out which ones...

Help needed to fix the remaining problems.

@Pttn Pttn removed their assignment Jul 15, 2020
@Pttn Pttn added the help wanted Extra attention is needed label Jul 15, 2020
@Pttn Pttn modified the milestones: Release 0.20, Riecoin 0.21+ Oct 18, 2020
@Pttn Pttn modified the milestones: Riecoin 0.21, Riecoin 22+ Apr 18, 2021
@Pttn Pttn modified the milestones: Riecoin 22+, Later Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed tests
Projects
None yet
Development

No branches or pull requests

2 participants