Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcut keys have no effect #393

Closed
GoogleCodeExporter opened this issue Mar 28, 2015 · 16 comments
Closed

Keyboard shortcut keys have no effect #393

GoogleCodeExporter opened this issue Mar 28, 2015 · 16 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Open Chrome 22, navigate to: 
https://chromiumcodereview.appspot.com/10928043/ (or any other issue)
2. Click on "View" link next to first file in a multiple-file patch set.
3. Press 'j' (or any other shortcut key).


What is the expected output? What do you see instead?

I'd expect the 'j' key would go on to the next file.  However, nothing happens. 
 None of the other shortcut keys do anything, either.  I've tried clicking 
around on the page to maybe change the keyboard focus, but that doesn't help.

No errors show up in the JavaScript console.

Nothing appears in the "Settings" page to turn keyboard shortcuts on or off.


What browser are you using?  What version? On what operating system?

Google Chrome   22.0.1229.26 (Official Build 153823) beta
OS  Linux
WebKit  537.4 (@126825)
JavaScript  V8 3.12.19.5
Flash   11.3.31.318
User Agent  Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.4 (KHTML, like 
Gecko) Chrome/22.0.1229.26 Safari/537.4
Command Line     /opt/google/chrome/google-chrome --flag-switches-begin 
--enable-experimental-extension-apis --flag-switches-end


At what URL are you accessing Rietveld?  (e.g. codereview.appspot.com)
Please note if you are using the Google Apps Labs version (e.g.
codereview.<yourdomain>).

chromiumcodereview.appspot.com


*** If you are a Google employee please say so or mail me (Guido van
Rossum) directly. ***

Yes, I am a Google employee.  ;-)


Please provide any additional information below.

The keyboard shortcuts *do* work for my teammate.  He's using Chrome 22 on a 
Mac laptop.  I have no idea why it isn't working for me.  One guess: I'm using 
the Dvorak keyboard layout, not Qwerty; but trying other keys doesn't work 
either.

Original issue reported on code.google.com by m...@google.com on 7 Sep 2012 at 12:27

@GoogleCodeExporter
Copy link
Author

I would agree that it's an issue with the Dvorak keyword layout. Does it work 
in other browsers? If you turn off the Dvorak thing?

Original comment by gvanrossum@gmail.com on 7 Sep 2012 at 6:42

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

I'm a non Google employee but we use Rietveld (its awesome). It is reproing for 
me as well, and for half my team. We are using Chrome 21, regular US input (not 
dvorak).

Original comment by ami...@gmail.com on 13 Sep 2012 at 10:43

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Half the team?  That sounds like there must be something specific. Can you do 
some research and see if there's a common factor between those for whom it 
doesn't work, e.g. OS or browser (specific versions may matter too) ?  Or type 
of account?

Original comment by gvanrossum@gmail.com on 13 Sep 2012 at 10:52

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

same problem on mac chrome 21.0.1180.89

works fine in safari, 4 of my teammates have the same problem

Original comment by gi...@cardspring.com on 13 Sep 2012 at 11:20

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

The plot thickens -- thanks for this info!  Could you try a newer Chrome 
version? I'm using Chrome 23 on MacOS and it does not have this issue.

Original comment by gvanrossum@gmail.com on 13 Sep 2012 at 11:38

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Interesting.  Just checked, and my development Chrome build (based on SVN rev 
156345) works just fine.

Google Chrome   23.0.1265.0 (Developer Build 156345)
OS  Linux
WebKit  537.10 (trunk@128017)
JavaScript  V8 3.13.7
Flash   11.3.31.331
User Agent  Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.10 (KHTML, like 
Gecko) Chrome/23.0.1265.0 Safari/537.10

Original comment by miu@chromium.org on 14 Sep 2012 at 12:11

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

installed Version 23.0.1262.0 dev

same issue

Original comment by Gila...@gmail.com on 14 Sep 2012 at 8:30

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

I'm having this problem. Using default US keyboard doesn't make a difference. 
Works in Firefox, fails in Chrome:

Google Chrome   21.0.1180.89 (Official Build 154005)
OS  Mac OS X
WebKit  537.1 (@126646)
JavaScript  V8 3.11.10.20

Original comment by kpreid@google.com on 14 Sep 2012 at 10:41

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

So what's the URL of the Rietveld instance you all are using?  I've been 
testing this on codereview.appspot.com.  If that's not the site where you are 
experiencing this, what is?  And can you check if it is broken on 
codereview.appspot.com too?

Original comment by gvanrossum@gmail.com on 14 Sep 2012 at 10:47

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Sorry, I'm using <https://codereview.appspot.com/>. I work on the Caja project 
<http://code.google.com/p/google-caja/> which uses that Rietveld instance for 
all its development.

Original comment by kpreid@google.com on 14 Sep 2012 at 10:58

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

[deleted comment]

1 similar comment
@GoogleCodeExporter
Copy link
Author

[deleted comment]

@GoogleCodeExporter
Copy link
Author

checked out http://codereview.appspot.com/ with chrome for mac version 
23.0.1262.0 dev, and shortcuts still don't have any effect.

the only error i see in js console is
Port error: Could not establish connection. Receiving end does not exist. 
miscellaneous_bindings:235
but i don't think that has anything to do with it, as i see it on every webpage.

Original comment by gi...@cardspring.com on 14 Sep 2012 at 11:07

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

That's really strange. Nothing changed in the JavaScript that drives Rietveld 
for a while. I'm using the same Chrome version as in comment #8 (except on 
Linux) without any problems.

Original comment by albrecht.andi on 15 Sep 2012 at 4:23

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

mystery solved, it was  getpocket.com chrome extension. removing it solved the 
problem

Original comment by Gila...@gmail.com on 20 Sep 2012 at 6:33

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Thanks for the feedback!

Original comment by albrecht.andi on 20 Sep 2012 at 7:12

  • Changed state: Invalid
  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant