Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the to_scan module process #15

Closed
jmons opened this issue Feb 13, 2020 · 2 comments
Closed

Change the to_scan module process #15

jmons opened this issue Feb 13, 2020 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@jmons
Copy link
Contributor

jmons commented Feb 13, 2020

This is an issue where new modules need to be added - but does it make sense to actually require this setting, i.e. shouldn't it be based on what modules there are in the discovery mode? And then allow (in future) config to --exclude particular modules (or white list), but by default use all available modules?

@jmons jmons added enhancement New feature or request question Further information is requested labels Feb 13, 2020
@jmons
Copy link
Contributor Author

jmons commented Feb 13, 2020

Also, discussion in team is to also change the region mode for AWS, so that the 'framework' will have a change to Resource, and that the AWSResource will do the region loop. AWSResources should also be able to implement a regionless flag of some kind, so that they are called once (e.g. dynamo / s3) to optimise speed.

@jmons
Copy link
Contributor Author

jmons commented Feb 13, 2020

Completed as part of #30

@jmons jmons closed this as completed Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant