Add rlogin, show message about missing gas, and minor cleanups #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a dependecy issue with babel-jest that was being installed from react-scripts. This is documented in FB's repo here: facebook/create-react-app#7169 Upgrading the react-scripts version "solved" this issue.
- Was not pulling data when they were checksumed. Could be a Windows issue.
- rLogin will handle the getting the network, this check is not needed and was crashing Metamask. - App now loads in Metamask.
- Add connect button that creates the instance and sets the provider and account
Trying the 'commit suggestion' feature from github. Co-authored-by: Ilan <36084092+ilanolkies@users.noreply.github.com>
ilanolkies
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds integration for rLogin rather than looking in the window object. Cleans up the Metamask error as this is being handled by rLogin now and the chainId and Metamask is not exposed to the application.
It also leaves redux in the app but does removes the checking of networkID actions.
Creates new dispense component/container to handle interacting with the smart contract to dispense RIF. This interacts with the existing redux state.
Resolves #1
Resolves #12