Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it error to use DotvvmView instead of DotvvmMarkupControl #1479

Open
exyi opened this issue Sep 28, 2022 · 0 comments
Open

Make it error to use DotvvmView instead of DotvvmMarkupControl #1479

exyi opened this issue Sep 28, 2022 · 0 comments
Milestone

Comments

@exyi
Copy link
Member

exyi commented Sep 28, 2022

When the user writes a dotvvm markup control with .dothtml extension and doesn't use @baseType directive, DotVVM will use DotvvmView as a base type. When the control is then initialized, there are multiple DotvvmViews in the page.

Easier solution is to make it an error to declare a markup control in such way. It's obviously breaking, so milestone 5.0

Alternative would be to use DotvvmMarkupControl as default base type, whenever the page is registered in DotvvmMarkupConfiguration. This is breaking too, if someone is using the page as view and also declared it as a control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant