Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean attributes without value #191

Closed
djanosik opened this issue Jun 9, 2016 · 3 comments
Closed

Boolean attributes without value #191

djanosik opened this issue Jun 9, 2016 · 3 comments

Comments

@djanosik
Copy link
Contributor

djanosik commented Jun 9, 2016

In HTML you can use boolean-like attributes without specifying a value. It would be nice if .dothml could support this.

<dot:Button IsSubmitButton="true" /> vs. <dot:Button IsSubmitButton />
@exyi
Copy link
Member

exyi commented Jun 9, 2016

It is quite good idea in my opinion. I'd add Switch property to MarkupOptionsAttribute which wound enable this behavior.

@tomasherceg
Copy link
Member

Can't we just enable it on all boolean properties?

@exyi
Copy link
Member

exyi commented Jun 11, 2016

@tomasherceg You are right, we can. I was just afraid that it can lead to unexpected behaviour on some properties, but I have not found any in the dotvvm core. I'll implement just after 1.0

@exyi exyi self-assigned this Jun 11, 2016
@exyi exyi added this to the Version 1.1 milestone Jul 9, 2016
@exyi exyi closed this as completed in e4cb327 Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants