Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split IGridViewDataSet in multiple interfaces #298

Closed
tomasherceg opened this issue Jan 5, 2017 · 4 comments
Closed

Split IGridViewDataSet in multiple interfaces #298

tomasherceg opened this issue Jan 5, 2017 · 4 comments

Comments

@tomasherceg
Copy link
Member

  • IDataSet
  • IPageableDataSet
  • ISortableDataSet
  • IFilterableDataSet
@djanosik
Copy link
Contributor

djanosik commented Mar 3, 2017

I think the names of interfaces should not contain the word "GridView", because we will also use it in other controls.

@tomasherceg
Copy link
Member Author

Agree, but:

  1. Since the GridViewDataSet was present in 1.0 and it is used on many pages in almost every app, it would be a big breaking change.
  2. The DataSet class is already taken and it would lead to a bigger confusion.

Maybe we could create the DotvvmDataSet and use type redirection, but I don't know what limitations or issues it would bring. We should do a research of this.

@tomasherceg tomasherceg reopened this Mar 3, 2017
@djanosik
Copy link
Contributor

djanosik commented Mar 5, 2017

I don't think we need one common DataSet implementation, but we need some common interfaces. We can surely keep GridViewDataSet and IGridViewDataSet. However, I think we shouldn't release this change until we know what we need from DataSets in BusinessPack.

@tomasherceg
Copy link
Member Author

Ygree, we should wait with further changes until we have e.g. grouping support in Business Pack GridView.

@tomasherceg tomasherceg modified the milestones: Version 1.2, Version 1.1 May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants