Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resources - Circular dependency - StackOverflow exception #710

Closed
MichalTichy opened this issue Jul 8, 2019 · 2 comments · Fixed by #714
Closed

Resources - Circular dependency - StackOverflow exception #710

MichalTichy opened this issue Jul 8, 2019 · 2 comments · Fixed by #714
Assignees
@cafour
Milestone
Version 2.4

Comments

@MichalTichy
Copy link
Contributor

Stack overflow exception is currently thrown when circular dependency exists in resources.
It would be better to throw some normal exception during resource registration.
@quigamdev
Copy link
Contributor

This check could be part of AssertConfigurationIsValid() method. @ENgateman

@cafour cafour mentioned this issue Jul 11, 2019
Merged
@cafour
Copy link
Contributor

cafour commented Jul 11, 2019

@quigamdev I didn't even know AssertConfigurationIsValid existed and according to its documentation it's supposed to validate only route paths. I added the check to DotvvmResourceRepository for the time being.

@exyi exyi added this to the Version 2.4 milestone Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cafour cafour

Labels
None yet
Projects
None yet
Milestone
Version 2.4
Development

Successfully merging a pull request may close this issue.

Detect circular dependencies among resources riganti/dotvvm
4 participants
@MichalTichy @exyi @quigamdev @cafour