Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port type parameter for circuit components #23

Open
ajkeller34 opened this issue Oct 30, 2019 · 0 comments
Open

Port type parameter for circuit components #23

ajkeller34 opened this issue Oct 30, 2019 · 0 comments

Comments

@ajkeller34
Copy link
Contributor

In src/circuit_components.jl, ports are assumed to be identified by Strings, but this not enforced elsewhere in the package. Probably the circuit components should have a type parameter for the port names.

See also #22; potentially one carefully thought out PR could address both issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ajkeller34