Merge server flags #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ecpeterson
force-pushed
the
merge-server-flags
branch
from
a68fdab
to
48ac0b9
Compare
notmgsk
suggested changes
Feb 1, 2019
app/src/entry-point.lisp
Outdated
|
|
||
| ;; configure the server | ||
| (unless (or port start-web-server) |
There was a problem hiding this comment.
start-web-server is not a variable
There was a problem hiding this comment.
nice catch @notmgsk
notmgsk
suggested changes
Feb 1, 2019
|
|
||
| ;; launch the polling loop | ||
| (show-banner) | ||
| (format t "~% | ||
| >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> IMPORTANT NOTICE <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< | ||
| The HTTP endpoint has been deprecated in favor of the RPCQ endpoint. In the |
There was a problem hiding this comment.
Should we note that an RPCQ server is being started
There was a problem hiding this comment.
The actual console output (sorta) indicates that. Is what's there insufficient?
There was a problem hiding this comment.
here's the sort of thing that gets emitted:
boson:quilc eric$ ./quilc -S -p 6000
+-----------------+
| W E L C O M E |
| T O T H E |
| R I G E T T I |
| Q U I L |
| C O M P I L E R |
+-----------------+
Copyright (c) 2016-2019 Rigetti Computing.
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> IMPORTANT NOTICE <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
The HTTP endpoint has been deprecated in favor of the RPCQ endpoint. In the
future, it will be removed. You're advised to modify your client code to talk
to the RPCQ version instead.
>>>>>>>>>>>>>>>>>>>>>>>>>>>>> END IMPORTANT NOTICE <<<<<<<<<<<<<<<<<<<<<<<<<<<<<
WARNING: -p and -S are incompatible. Dropping -p.
<134>1 2019-02-01T19:30:28Z boson.lan ./quilc 5649 LOG0001 - Launching quilc.
<134>1 2019-02-01T19:30:28Z boson.lan ./quilc 5649 - - Spawning server at (tcp://*:5555) .
[2019-02-01 14:30:28] Starting server: 0.0.0.0 : 6000.
There was a problem hiding this comment.
IMO it's not clear. I think I might be confused if I saw that two servers were being spawned when I only requested one.
There was a problem hiding this comment.
I'll add some more text to the IMPORTANT NOTICE.
There was a problem hiding this comment.
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> IMPORTANT NOTICE <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
The HTTP endpoint has been deprecated in favor of the RPCQ endpoint. In the
future, it will be removed. In the meanwhile, we are launching *both* an HTTP
server and an RPCQ server. You're advised to modify your client code to talk
to the RPCQ version instead, so that it continues to operate when we disable the
HTTP server for good.
>>>>>>>>>>>>>>>>>>>>>>>>>>>>> END IMPORTANT NOTICE <<<<<<<<<<<<<<<<<<<<<<<<<<<<<
mpharrigan
approved these changes
Feb 1, 2019
ecpeterson
force-pushed
the
merge-server-flags
branch
from
48ac0b9
to
7a823b4
Compare
notmgsk
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the transition from the HTTP server to the RPCQ server more painless: when quilc is launched with
-S, it launches the RPCQ server in addition to the web server, so that modern pyQuil is about to quietly use the new endpoint.