Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RZFInteractionDelegate contract is strange #5

Open
bskinner opened this issue Feb 16, 2016 · 0 comments
Open

RZFInteractionDelegate contract is strange #5

bskinner opened this issue Feb 16, 2016 · 0 comments

Comments

@bskinner
Copy link
Contributor

The delegation implementation in RZFUpgradeManager has several issues which could lead to confusing behavior when used, and present consumers of the library with difficulties if they want alternate behavior. The current behavior of the RZFUpgradeManager is:
0. If nothing is currently presented, a single UpdatePrompt or ReleaseNotes modal can be presented

  1. An UpdatePrompt modal may dismiss a currently presented ReleaseNotes modal
  2. When presenting an update message, if an UpdatePrompt modal is already presented, do nothing.
  3. When presenting a release notes message, if either a UpdatePrompt or ReleaseNotes is currently being presented, do nothing.

This logic should be moved out of the RZFUpgradeManager and into the default interaction delegate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant