Call object.dump in rendered for Dumpable instances #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fully dumping an object (i.e., when no subfields were selected), that is not a Blueprint, ensure we call `object.dump` if they have the Attributor::Dumpable module. Signed-off-by: Josep M. Blanquer <blanquer@rightscale.com>
blanquer
force-pushed
the
26_utilize_attributor_dumpable_while_rendering
branch
from
2a64bd0
to
c1dd6cd
Compare
|
LGTM, pending rightscale/attributor#158 |
Signed-off-by: Dane Jensen <dane@rightscale.com>
careo
force-pushed
the
26_utilize_attributor_dumpable_while_rendering
branch
from
cff2489
to
beec198
Compare
careo
pushed a commit
that referenced
this pull request
Feb 18, 2016
…_while_rendering Call object.dump in rendered for Dumpable instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fully dumping an object (i.e., when no subfields were selected), that is not a Blueprint, ensure we call
object.dumpif they have the Attributor::Dumpable module.In other words, attributor types (custom or not) will need to include the
Attributor::Dumpablemodule and properly implement thedumpinstance method to produce the right output with native ruby objects.fixes #26
Signed-off-by: Josep M. Blanquer blanquer@rightscale.com