Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix corner case bug rendering nil subjects #30

Merged
merged 5 commits into from Aug 11, 2016
Merged

Fix corner case bug rendering nil subjects #30

merged 5 commits into from Aug 11, 2016

Conversation

blanquer
Copy link
Contributor

Note: It would only manifest when include_nil is true and there’s an explicit subsection of fields.

Signed-off-by: Josep M. Blanquer blanquer@gmail.com

@blanquer
Fix corner case bug rendering nil subjects
2c160a9 
Note: It would only manifest when include_nil is true and there’s an explicit subsection of fields.
@coveralls
Copy link

coveralls commented Aug 11, 2016 •
edited

Coverage Status

Coverage increased (+0.03%) to 96.398% when pulling 2c160a9 on rendering_nil_subobjects into b74c821 on master.

@blanquer
Bump ruby 2.2.x version for travis.
f748978 
Signed-off-by: Josep M. Blanquer <blanquer@gmail.com>
@coveralls
Copy link

coveralls commented Aug 11, 2016 •
edited

Coverage Status

Coverage increased (+0.03%) to 96.398% when pulling f748978 on rendering_nil_subobjects into b74c821 on master.

@blanquer
Use .concat to appease the cops a little bit.
cf5c653 
Signed-off-by: Josep M. Blanquer <blanquer@gmail.com>
@coveralls
Copy link

coveralls commented Aug 11, 2016 •
edited

Coverage Status

Coverage increased (+0.03%) to 96.398% when pulling cf5c653 on rendering_nil_subobjects into b74c821 on master.

@coveralls
Copy link

coveralls commented Aug 11, 2016 •
edited

Coverage Status

Coverage decreased (-0.09%) to 96.283% when pulling cbfccef on rendering_nil_subobjects into b74c821 on master.

@coveralls
Copy link

coveralls commented Aug 11, 2016 •
edited

Coverage Status

Coverage decreased (-0.09%) to 96.283% when pulling 62f1237 on rendering_nil_subobjects into b74c821 on master.

@coveralls
Copy link

coveralls commented Aug 11, 2016 •
edited

Coverage Status

Coverage decreased (-0.09%) to 96.283% when pulling 95b393a on rendering_nil_subobjects into b74c821 on master.

@blanquer
Try to appease the cops about method_missing.
3101a5a 
Signed-off-by: Josep M. Blanquer <blanquer@gmail.com>
@coveralls
Copy link

coveralls commented Aug 11, 2016 •
edited

Coverage Status

Coverage decreased (-0.09%) to 96.283% when pulling 3101a5a on rendering_nil_subobjects into b74c821 on master.

@blanquer
Build specs for config_hash (to appease coveralls)
fa070ad 
Signed-off-by: Josep M. Blanquer <blanquer@gmail.com>
@coveralls
Copy link

coveralls commented Aug 11, 2016 •
edited

Coverage Status

Coverage increased (+1.7%) to 98.111% when pulling fa070ad on rendering_nil_subobjects into b74c821 on master.

@careo
Copy link
Contributor

careo commented Aug 11, 2016

LGTM

@blanquer blanquer merged commit e276478 into master Aug 11, 2016
@blanquer blanquer deleted the rendering_nil_subobjects branch August 4, 2017 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blanquer @coveralls @careo