Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use secure connection #238

Open
m4tx opened this issue May 17, 2024 · 0 comments
Open

Always use secure connection #238

m4tx opened this issue May 17, 2024 · 0 comments

Comments

@m4tx
Copy link
Member

m4tx commented May 17, 2024

Commit 14222ff has added an invocation of danger_accept_invalid_certs(). This has been considered safe because:

  1. The data being downloaded is a static image anyway, and no user-provided data is being sent
  2. The issue seems to be on the server side, as many tools and operating systems seems to be complaining about fetching the data with the same error being returned (unable to get local issuer certificate, visible at least on Arch and Debian Linux).

Ideally though, we'd like to eventually get rid of it - perhaps the server will fix the issue, or we'll figure out some other way to not call this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant