Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling for getaddrinfo failing. #57

Open
rikai opened this issue May 22, 2016 · 4 comments
Open

Add error handling for getaddrinfo failing. #57

rikai opened this issue May 22, 2016 · 4 comments

Comments

@rikai
Copy link
Owner

rikai commented May 22, 2016

03:06:40 irc.1  | [2016/05/22 03:06:40.436] !! /home/rikai/.rvm/gems/ruby-2.3.1/gems/httpclient-2.6.0.1/lib/httpclient/session.rb:799:in 'initialize': getaddrinfo: Name or service not known (http://jbtitties.com:80) (SocketError)

This looks like crap, lets handle it

@cbojar
Copy link
Collaborator

cbojar commented May 22, 2016

Is this error copied verbatim? In which case, do you see something... funny... about it? Say, maybe in the URL it says it can't find? Perhaps a typo in configuration somewhere?

@rikai
Copy link
Owner Author

rikai commented May 22, 2016

It's the generic error you get from httpclient when a URL doesn't resolve. It'd be nice to catch it and make it look nice, or supress it i guess, but the former would be preferred.

I'm just in a mood where i'm adding lots of small polish bugs that new contributors or existing contributors wanting to knock off small little things can work on. 💯

@cbojar
Copy link
Collaborator

cbojar commented May 22, 2016

Ah, so that's just a dummy URL. I was wondering about that... 😎

@rikai
Copy link
Owner Author

rikai commented May 23, 2016

People in the chatroom being silly :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants