Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'silent mode' #64

Open
rikai opened this issue Aug 14, 2016 · 6 comments
Open

Implement 'silent mode' #64

rikai opened this issue Aug 14, 2016 · 6 comments

Comments

@rikai
Copy link
Owner

rikai commented Aug 14, 2016

A silent mode, where the bot receives commands, but does not output a response would be extremely useful for debugging things under a similar load to a real bot.

Probably one of the easiest ways to track down #61 would be to run a second bot in the same channel in this mode, so it's under similar load without interfering with the main bot's functionality.

Note: This shouldn't just neuter commands, it should try to implement as much as possible, including sending the messages, without the messages actually getting sent, to be as faithful as possible to the setup being debugged.

So maybe something that intercepts/redirects sent messages to stdout instead of irc when the event is fired or something, rather than than stopping messages from being sent at all. Feel free to sanity check me on this though, just thinking myself that the later in the process this is done, the better it will be for debugging.

@cbojar
Copy link
Collaborator

cbojar commented Aug 15, 2016

Since this would be a completely separate issue, maybe run it behind ZNC and use something like https://github.com/gongo/znc-rom.

@rikai
Copy link
Owner Author

rikai commented Aug 15, 2016

I refuse to touch ZNC, but nelsk might be willing to do so for debugging... :P

@eriknelson
Copy link
Collaborator

@rikai Yeah let's make nelsk deal with it 👍

@rikai
Copy link
Owner Author

rikai commented Aug 15, 2016

@cbojar @eriknelson TBH, i think adding another thing into the chain is a worse idea than handling it internally, even if i didn't dislike ZNC. :P

@eriknelson
Copy link
Collaborator

It should be easy to monkey patch cinch to write output to a logger.

@rikai
Copy link
Owner Author

rikai commented Jun 1, 2017

If anyone feels like picking up where @herbmillerjr left off in #76 we can probably get this one knocked out.

The TL;DR from that issue is that the place where the message is caught needs to be moved to a later position and that there needs to be a way to whitelist plugins to bypass this to minimize breakage of things like cinch-identify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants