Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: ProtocolChecksum should not use ".FullName" #70

Open
rikimaru0345 opened this issue Oct 14, 2019 · 0 comments
Open

Bug: ProtocolChecksum should not use ".FullName" #70

rikimaru0345 opened this issue Oct 14, 2019 · 0 comments
Assignees
@rikimaru0345
Labels
bug Something isn't working Low Priority
Milestone
Ceras v5.0

Comments

@rikimaru0345
Copy link
Owner

The ProtocolChecksum will not match if a project is compiled for different runtimes.
It uses type.FullName, which includes the assembly Name/Version/...
None of those things should be included.

Fix: just using .FriendlyName(true) or something like instead that should do the trick (along with a bunch of unit-tests!)

Not sure when I'll get around to fixing this, but I hope I can work on it tomorrow.
@rikimaru0345 rikimaru0345 added the bug Something isn't working label Oct 14, 2019
@rikimaru0345 rikimaru0345 self-assigned this Oct 14, 2019
@rikimaru0345 rikimaru0345 added this to the Ceras v5.0 milestone Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rikimaru0345 rikimaru0345

Labels
bug Something isn't working Low Priority
Projects
None yet
Milestone
Ceras v5.0
Development

No branches or pull requests
1 participant
@rikimaru0345