Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a .jshintrc specifically tailored for ConditionerJS #26

Closed
branneman opened this issue May 14, 2013 · 3 comments
Closed

Add a .jshintrc specifically tailored for ConditionerJS #26

branneman opened this issue May 14, 2013 · 3 comments

Comments

@branneman
Copy link
Contributor

Maybe use this one as a template?

https://github.com/branneman/frontend-bootstrap/blob/master/.jshintrc

@rikschennink
Copy link
Owner

Thanks! File has been added.

@branneman
Copy link
Contributor Author

I don't think it's working yet. You're going to need to specify the jshintrc as a setting to grunt-contrib-jshint. You'll always need this to be able to run grunt jshint. Read more here: https://github.com/gruntjs/grunt-contrib-jshint#jshintrc

However, when using that option, it parses the file as JSON, which doesn't allow for comments, so will raise an error if you keep the comments from my file. Since I didn't agree with JSON as a config file format (config files should allow for comments), but we're stuck with it anyway, I included the JSON.minify() lib. I configured my jshint task in my gruntfile as follows: https://github.com/branneman/frontend-bootstrap/blob/master/gruntfile.js#L120

If you'd like the comments, you're going to need a solution like mine. You can however also just remove the comments and be done with it as well :)

@rikschennink
Copy link
Owner

done, copped out, no comments for me. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants