Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline doesn't upscale text after breaking it #41

Closed
ciriousjoker opened this issue Mar 27, 2019 · 8 comments
Closed

Multiline doesn't upscale text after breaking it #41

ciriousjoker opened this issue Mar 27, 2019 · 8 comments

Comments

@ciriousjoker
Copy link

"Some word" fits into a container.
Then the container shrinks and it becomes
"Some
word".
Now, there would be enough width available to scale the text up, but it's not happening :(

@rikschennink
Copy link
Owner

Please supply a test case

@ciriousjoker
Copy link
Author

Here it is:

https://codepen.io/ciriousjoker/pen/vMEBZN

Set view to side by side and resize until the text wraps into the second line. Notice how the font size stays the same as directly before wrapping.

@rikschennink
Copy link
Owner

Ah, okay, now I understand. Fitty simply doesn't rescale wrapped text. It only handles single lines. You'd have to split the line yourself.

@ciriousjoker
Copy link
Author

ciriousjoker commented Apr 2, 2019

Then I don't get how Multiline works. I thought Multiline is the same as Singleline in that it rescales until the minimum font size and when it doesn't work anymore it splits it into two lines and starts from max fitting font size again.

Since it's not that way, do you have any plans to implement that?

@rikschennink
Copy link
Owner

It will force text on multiple lines if it no longer fits the container (if minSize reached).

It would require a totally different approach, as I'm super busy with other projects I don't have the time to look into it.

@ciriousjoker
Copy link
Author

Ok, no problem, I found another solution in my case.

@HugoHeneault
Copy link

@ciriousjoker Would you mind sharing your solution? I'm also looking for a nice way to do that! Thanks! 🍻

@ciriousjoker
Copy link
Author

@HugoHenault Sorry, not really. I just made the surroundings look nice so it doesn't look bad. Far from perfect, but works for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants