Support linking with lower version OS #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift PM does not have a good way to conditionally include a package. That means that apps targeting a lower OS version cannot import AltKit. As a workaround, we lower the linking version while inserting availability checks into AltKit. Since NWConnection requires iOS 12, we will return an error when trying to connect with iOS 11.
|
That's unfortunate we can't weak-link Swift Package, but since we can't do anything about that I agree this is a reasonable workaround. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift PM does not have a good way to conditionally include a package. That
means that apps targeting a lower OS version cannot import AltKit. As a
workaround, we lower the linking version while inserting availability
checks into AltKit.
Since NWConnection requires iOS 12, we will return an error when trying to
connect with iOS 11.