Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Change App Icon Functionality #130

Closed

Conversation

ianclawson
Copy link

Implements the ability to change app icon as discussed in the AltStore Discord, using the icons provided therein.

Relevant Trello Card: https://trello.com/c/lBhuBBj4/174-qol-provide-a-series-of-app-icons-in-app-to-switch

@lonkelle
Copy link
Collaborator

More Alternative Icons by @kylegrieder attached.

Kyle Grieder's Alternate Delta Icons.zip

@ianclawson
Copy link
Author

IMG_5710B9BEBED4-1

IMG_6565BC0324B1-1

@lonkelle
Copy link
Collaborator

lonkelle commented Jul 12, 2021

@ianclawson This is absolutely perfect, would it be difficult to throw in a commit to round the corners (like iOS does to it's icons) to show what the user exactly what the icon will look like?

And maybe "Pride 1" and "Pride 2" could be "Pride" and "Pride (Gradient)" - or do ya think the numbering looks better?

@ianclawson
Copy link
Author

@ianclawson This is absolutely perfect, would it be difficult to throw in a commit to round the corners (like iOS does to it's icons) to show what the user exactly what the icon will look like?

And maybe "Pride 1" and "Pride 2" could be "Pride" and "Pride (Gradient)" - or do ya think the numbering looks better?

Appreciate the feedback! I much prefer your suggested "Pride" and "Pride (Gradient)" so I'll update accordingly 👍

For the rounded corners, I'll give it a shot! It's def possible using a custom cell (right now I'm using a default one) but I'll first try an approach using the default cell to see if I can make any gains there without extending the PR much more.

@ianclawson
Copy link
Author

ianclawson commented Jul 13, 2021

@lonkle updated! Adding the App Icon curve is such a nice touch -- I'm mad I didn't think of it! 😂 Thanks for the recommendation.

IMG_DC12EE2BA2F0-1

@lonkelle
Copy link
Collaborator

It looks great! And this is why we work on things together! Two pairs of eyes. 😉 I updated the Trello card cover image with your new screenshot and it looks awesome!

@ianclawson
Copy link
Author

Closing this PR (kinda) in favor of another PR I will be opening in the next few days.

I just realized I'm working on 3 separate smaller QoL enhancements that all have to do with configuring the app's appearance in some way, and so realized from a UI perspective it makes sense to consolidate those into an "Appearance Settings" screen, therefore it would be cleaner to wrap all of those into a single PR.

I'm halfway through the final enhancement now, so I'm hoping to have the other PR ready by the end of the week 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants