Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual screen emulators top screen go under the notch #40

Closed
Baza207 opened this issue Nov 7, 2019 · 5 comments
Closed

Dual screen emulators top screen go under the notch #40

Baza207 opened this issue Nov 7, 2019 · 5 comments

Comments

@Baza207
Copy link

Baza207 commented Nov 7, 2019

With iPhones such as the X, Xs, XR and 11, an emulator with dual screens, such as the DS, will go under the notch, at times covering up text or information shown across the top of that screen when in portrait.

In landscape it's better (the controls are in enough or respect the safe area), but the "Menu" button will then cover that section of the top screen, and the "Select" and "Start" buttons would cover the bottom of the lower screen.

I'm not sure what to suggest for portrait, as space is limited as it is, so moving it down might squish things up a bit (I might try later if I can get into the code for the project, just to see what it looks like). But for landscape, I feel that the "Menu", "Select" and "Start" button might be best going in the middle(ish) to the left and right side of the screen where there's a lot of empty black space, so they don't cover anything up.

Not sure how people feel about how in-depth settings should be, but maybe something to be added to settings, to respect or go under the notch depending on what the user prefers?

I've added some screen shots to show the issue with an overlay of where the notch will be.

IMG_6457_wNotch
IMG_6458

@jimm-e
Copy link

jimm-e commented Nov 7, 2019

This skin is only a placeholder skins as DS is in beta. You can download any of the custom skins for DS and they all fix this issue.

@Baza207
Copy link
Author

Baza207 commented Nov 7, 2019

Oh I see that now. I'd missed all the wiki stuff in DeltaCore. I'll have a play around with this then. Thanks for the heads up. 😄

@Baza207 Baza207 closed this as completed Nov 7, 2019
@jimm-e
Copy link

jimm-e commented Nov 7, 2019

I made a website with skins already made by the community, https://delta-skins.github.io/. There you can find lots of DS skins.

@Baza207
Copy link
Author

Baza207 commented Nov 7, 2019

Oh great, thanks! Looking at tweaking my own (more than just the 30point offset I've done for now) at some point. If I do, do you have a way to submit for that site, or should I just post here?

@jimm-e
Copy link

jimm-e commented Nov 7, 2019

You can submit them on the Delta discord: https://discord.gg/ERssHqy. You can also find resources and ask questions about skin making or Delta in general there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants