Infer type of ZodEffects schemas using zx.parseFormSafe
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdoury
changed the title
ZodEffect schemas using zx.parseFormSafeZodEffects schemas using zx.parseFormSafe
|
Another good catch. Thanks for adding the additional test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zx.parseFormSafeis able to parseZodEffectsschemas but it fails to infer the types.I added a failing test to reproduce issue #17 but I wasn't able to fix it instantly so I will leave it there for now.
I will look into it next week probably.
@rileytomasek I did not dig into
zodtypings so far, do you have any idea how to handle this?EDIT: I found a way to fix the type inference of result.error when user is parsing a
ZodEffectsschema withzx.parsFormSafe.Fixes #17