Skip to content
This repository has been archived by the owner on Dec 17, 2022. It is now read-only.

pulse max sample count #8

Open
lelongg opened this issue Mar 19, 2021 · 2 comments
Open

pulse max sample count #8

lelongg opened this issue Mar 19, 2021 · 2 comments

Comments

@lelongg
Copy link

lelongg commented Mar 19, 2021

How about adding a constructor to pulse for specifying the max sample count to store ?

@therustmonk
Copy link
Contributor

Thanks! No problem, I think we can do it for the next release.

In general, do you want to store more or less data? Or the chart is rendering wrong? Or maybe you want to keep the data by a time interval instead of explicit quantity?

@therustmonk therustmonk added this to Features In Progress in Release Plan Mar 19, 2021
@lelongg
Copy link
Author

lelongg commented Mar 19, 2021

In this case, I would like to store more data. I would not say that the chart is rendering wrong but it's definitely strange. I update the pulse at 100Hz and the left end of the chart is always flat like in the screenshot below. I assume the old samples are thrown away before being able to reach the left end.

image

Being able to have a fixed time window for the chart would also do the job, maybe even better since in some use case I don't always have a fixed sample rate.

By the way I use rillrate to display live data from a robot and it's very nice. It looks like its going to be the tool I missed for so long. Thanks for your work !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Release Plan
Nearest Plans
Development

No branches or pull requests

2 participants