Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow simplifier to return empty comment #541

Merged
merged 5 commits into from Jun 7, 2022

Conversation

LEOYoon-Tsaw
Copy link
Member

@LEOYoon-Tsaw LEOYoon-Tsaw commented Apr 18, 2022

by adding "allow_erase_comment" argument

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Allow simplifier to return empty comment. There are situations that I want simplifier to erase comment and return empty comment. For example in emoji conversion, I don't want converted emoji to have readings from reverse_look_up filter.

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

by adding "allow_erase_comment" argument
@lotem lotem self-requested a review April 21, 2022 14:13
Copy link
Member

@lotem lotem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful option.

I suggested a more appropriate name.

src/rime/candidate.h Outdated Show resolved Hide resolved
@lotem
Copy link
Member

lotem commented Jun 6, 2022

Now I found that overwrite_comment: is confusing when set to false; it makes one think that when the original candidate has a comment, it won't ever be overwritten.

Anyway, I requested editing. I had to accept it.

@lotem lotem self-requested a review June 6, 2022 17:07
@lotem
Copy link
Member

lotem commented Jun 6, 2022

Do you like the last rename? @LEOYoon-Tsaw

@LEOYoon-Tsaw
Copy link
Member Author

Yeah, looks good

@lotem lotem merged commit 2368034 into rime:master Jun 7, 2022
@LEOYoon-Tsaw LEOYoon-Tsaw deleted the empty_comment branch June 7, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants