Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding data_readers for clj-time or coercing to timestamp #464

Closed
vkz opened this issue Apr 4, 2022 · 1 comment
Closed

Consider adding data_readers for clj-time or coercing to timestamp #464

vkz opened this issue Apr 4, 2022 · 1 comment

Comments

@vkz
Copy link

vkz commented Apr 4, 2022

This bit here will break unable to edn/read-string if ever you attempt to store clj-time/date-time value, which you do e.g. in ring.middleware.oauth2 when writing token expiry in session map here.

Possible solutions:

  • ensure clj-time's data_readers.clj or at least clj-time.coerce is loaded by the session/cookie middleware,
  • don't store oauth2 time as clj-time at all, instead convert to timestamp instance, which edn reader can handle

Thanks

@vkz
Copy link
Author

vkz commented Apr 4, 2022

oops, I take it back. Looks like cookie-store offers a :readers option. My bad. Closing

@vkz vkz closed this as completed Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant